Use wayland protocol to show monitor labels#401
Open
leolost2605 wants to merge 5 commits into
Open
Conversation
leolost2605
force-pushed
the
leolost/monitor-labels-protocol
branch
4 times, most recently
from
373029e to
9c9e677
Compare
leolost2605
force-pushed
the
leolost/monitor-labels-protocol
branch
from
9c9e677 to
0ea6adf
Compare
# Conflicts fixed: # src/Widgets/DisplaysOverlay.vala
Collaborator
|
This fixes the label issue with Wayland but introduces one with Classic session. Not sure if that is a problem if this will only be released with OS9? However, if it is not released with OS8 then the issue will persist there for sometime yet. Is it worth coping with both sessions? |
Collaborator
|
On closer inspection the code does attempt to cope with an X11 session so I'll try and fix that. CI is failing for stable for some reason (pantheon-wayland-1 should be present in OS8) |
Collaborator
|
Could not get this PR to work satisfactorily in X11 session (the monitor labels appeared in an incorrect position after "Detect Displays" was clicked. To save time I have incorporated the Wayland stuff while keeping the existing X11 stuff for now in PR #445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with elementary/gala#2084 and elementary/pantheon-wayland#3